Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2: upgrade modulename to v2 #1552

Merged
merged 6 commits into from
Apr 17, 2023
Merged

V2: upgrade modulename to v2 #1552

merged 6 commits into from
Apr 17, 2023

Conversation

Nerzal
Copy link
Contributor

@Nerzal Nerzal commented Apr 14, 2023

Describe the PR
In order to be able to import the package with a v2 version, we need to add /v2 to the module name

Else we get this error:

go: github.com/swaggo/swag/[email protected]: go.mod has non-.../v2 module path "github.com/swaggo/swag" (and .../v2/go.mod does not exist) at revision v2.0.0-beta

@Nerzal Nerzal marked this pull request as draft April 14, 2023 03:16
@Nerzal Nerzal added the v2 Used for all v2 related issues label Apr 14, 2023
@Nerzal Nerzal marked this pull request as ready for review April 14, 2023 03:35
@Nerzal
Copy link
Contributor Author

Nerzal commented Apr 14, 2023

I'm not sure how to correctly test this change without merging and creating a new tag.
So i'd suggest to merge this and i'll fix all issues then

@Nerzal Nerzal changed the title upgrade modulename to v2 V2: upgrade modulename to v2 Apr 14, 2023
@Nerzal
Copy link
Contributor Author

Nerzal commented Apr 14, 2023

@ubogdan can u tell me why snyk is complaining?

Also is there a reason why snyk is not related to the swaggo organisation and instead tied to your personal account?

@ubogdan
Copy link
Contributor

ubogdan commented Apr 17, 2023

@Nerzal I manage to link it to swaggo org.

@ubogdan ubogdan merged commit 44b59ad into swaggo:v2 Apr 17, 2023
@Nerzal
Copy link
Contributor Author

Nerzal commented Apr 17, 2023

Nice, I'll now fix possible issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2 Used for all v2 related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants